Hi Bodek, > -----Original Message----- > From: zbigniew.bo...@caviumnetworks.com > [mailto:zbigniew.bo...@caviumnetworks.com] > Sent: Wednesday, January 18, 2017 2:27 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo; Doherty, Declan; > jerin.ja...@caviumnetworks.com; jianbo....@linaro.org; > hemant.agra...@nxp.com; Zbigniew Bodek > Subject: [PATCH v5 4/7] doc: update documentation about ARMv8 crypto > PMD > > From: Zbigniew Bodek <zbigniew.bo...@caviumnetworks.com> > > Add documentation about the driver and update > release notes. > > Signed-off-by: Zbigniew Bodek <zbigniew.bo...@caviumnetworks.com> > Reviewed-by: Jerin Jacob <jerin.ja...@caviumnetworks.com> > --- > doc/guides/cryptodevs/armv8.rst | 96 > ++++++++++++++++++++++++++++++++++ > doc/guides/cryptodevs/index.rst | 1 + > doc/guides/rel_notes/release_17_02.rst | 5 ++ > 3 files changed, 102 insertions(+) > create mode 100644 doc/guides/cryptodevs/armv8.rst > > diff --git a/doc/guides/cryptodevs/armv8.rst > b/doc/guides/cryptodevs/armv8.rst > new file mode 100644 > index 0000000..ca8781e > --- /dev/null > +++ b/doc/guides/cryptodevs/armv8.rst
... > + > +ARMv8 Crypto Poll Mode Driver > +================================ Extra "===" here. > + > +This code provides the initial implementation of the ARMv8 crypto PMD. > +The driver uses ARMv8 cryptographic extensions to process chained > crypto > +operations in an optimized way. The core functionality is provided by > +a low-level library, written in the assembly code. > + > +Features > +-------- > + > +ARMv8 Crypto PMD has support for the following algorithm pairs: > + > +Supported cipher algorithms: > +* ``RTE_CRYPTO_CIPHER_AES_CBC`` Add a blank like before starting a list (same below). > + > +Supported authentication algorithms: > +* ``RTE_CRYPTO_AUTH_SHA1_HMAC`` > +* ``RTE_CRYPTO_AUTH_SHA256_HMAC`` > + Could you add an entry on the "Crypto Device Supported Functionality Matrices", to show supported algorithms and feature flags? It is in doc/guides/cryptodevs/overview.rst. There should be a column per crypto device (I just realized that I missed one for ZUC PMD, so I will send a patch shortly, and then you can rebase it on top of it). The rest of the patchset looks good to me, so once you send another version, I will merge it. Thanks, Pablo
