The tag "Cc: sta...@dpdk.org" must be set when the commit must be
backported to a stable branch. The reminder is reworded.
It should be located just below the "Fixes:" tag (without blank line)
and followed by a blank line, separated from SoB and review tags below.
However, there is no strong need for checking blank lines.
Signed-off-by: Thomas Monjalon <thomas.monja...@6wind.com>
---
v2: relax checking and reword reminder
v1: strict checking of blank lines while allowing Cc: stable
---
devtools/check-git-log.sh | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh
index f6a35d2..62b5f43 100755
--- a/devtools/check-git-log.sh
+++ b/devtools/check-git-log.sh
@@ -170,12 +170,6 @@ bad=$(echo "$tags" |
sed 's,^.,\t&,')
[ -z "$bad" ] || printf "Wrong tag:\n$bad\n"
-# check blank line after last Fixes: tag
-bad=$(echo "$bodylines" |
- sed -n 'N;/\nFixes:/D;/\n$/D;/^Fixes:/P' |
- sed 's,^.,\t&,')
-[ -z "$bad" ] || printf "Missing blank line after 'Fixes' tag:\n$bad\n"
-
# check missing Fixes: tag
bad=$(for fix in $fixes ; do
git log --format='%b' -1 $fix | grep -q '^Fixes: ' ||
@@ -198,9 +192,9 @@ bad=$(for fixtag in $fixtags ; do
done | sed 's,^,\t,')
[ -z "$bad" ] || printf "Wrong 'Fixes' reference:\n$bad\n"
-# check CC:stable for fixes
+# check Cc: sta...@dpdk.org for fixes
bad=$(for fix in $stablefixes ; do
- git log --format='%b' -1 $fix | grep -qi '^CC: *sta...@dpdk.org' ||
+ git log --format='%b' -1 $fix | grep -qi '^Cc: *sta...@dpdk.org' ||
git log --format='\t%s' -1 $fix
done)
-[ -z "$bad" ] || printf "Should CC: sta...@dpdk.org\n$bad\n"
+[ -z "$bad" ] || printf "Is it candidate for Cc: sta...@dpdk.org
backport?\n$bad\n"
--
2.7.0
