2017-01-17 19:07, Shreyansh Jain: > +static int > +rte_eal_pci_detach_dev(struct rte_pci_driver *dr, > + struct rte_pci_device *dev) > +{ > + int ret; > + struct rte_pci_addr *loc; > + > + if ((dr == NULL) || (dev == NULL)) > + return -EINVAL; > + > + ret = rte_pci_match(dr, dev);
I do not understand this function. The driver should be known by the device at this stage. Why specifying a driver as parameter? I know it is not new in this series, but pci_detach_all_drivers(struct rte_pci_device *dev) makes no sense to me.