Hi Shahaf, On 1/16/2017 1:30 PM, Shahaf Shuler wrote: > Implement extended statistics callbacks. > > Suggested-by: Hanoch Haim <hh...@cisco.com> > Signed-off-by: Shahaf Shuler <shah...@mellanox.com> > Signed-off-by: Elad Persiko <ela...@mellanox.com>
I am getting following build error [1] with clang when MLX5_DEBUG=y, this seems because of pedandic. Variable length array supported by language with c99 but mlx is forcing to compile itself with gnu99 (-std=gnu99), not sure why, which supports variable length array as an extension. [1] .../drivers/net/mlx5/mlx5_stats.c:266:20: error: variable length array folded to constant array as an extension [-Werror,-Wgnu-folding-constant] uint64_t counters[xstats_n]; ^~~~~~~~ .../drivers/net/mlx5/mlx5_stats.c:289:20: error: variable length array folded to constant array as an extension [-Werror,-Wgnu-folding-constant] uint64_t counters[xstats_n]; ^~~~~~~~