HI, yigit > -----Original Message----- > From: Yigit, Ferruh > Sent: Saturday, January 7, 2017 1:20 AM > To: Zhao1, Wei <wei.zh...@intel.com>; dev@dpdk.org > Cc: Lu, Wenzhuo <wenzhuo...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v2 13/18] net/ixgbe: parse TCP SYN filter > > On 12/30/2016 7:53 AM, Wei Zhao wrote: > > check if the rule is a TCP SYN rule, and get the SYN info. > > > > Signed-off-by: Wei Zhao <wei.zh...@intel.com> > > Signed-off-by: Wenzhuo Lu <wenzhuo...@intel.com> > > > > --- > > > > v2:add new error set function > > --- > > <...> > > > +static int > > +ixgbe_parse_syn_filter(const struct rte_flow_attr *attr, > > + const struct rte_flow_item pattern[], > > + const struct rte_flow_action actions[], > > + struct rte_eth_syn_filter *filter, > > + struct rte_flow_error *error) { > > + int ret; > > + > > + ret = cons_parse_syn_filter(attr, pattern, > > + actions, filter, error); > > + > > > + if (ret) > > + return ret; > > + > > + return 0; > > "return ret;" will do the same. > Or remove ret completely perhaps.
Return 0 is the same as "return ret;", so this may be not to need change. > > > +} > > + > <...>