> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Slawomir > Mrozowicz > Sent: Thursday, January 05, 2017 4:50 PM > To: dev@dpdk.org > Cc: Mrozowicz, SlawomirX; Doherty, Declan; Kerlin, Marcin > Subject: [dpdk-dev] [PATCH v2 2/3] lib/librte_cryptodev: functions for new > performance test application > > This patch adds helper functions for new performance application. > Application can be used to measute throughput and latency of > cryptography operation performed by crypto device. > > Signed-off-by: Declan Doherty <declan.dohe...@intel.com> > Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozow...@intel.com> > Signed-off-by: Marcin Kerlin <marcinx.ker...@intel.com>
Hi Slawomir, You should change the title of this patch to something like: "cryptodev: add functions for...". Also, maybe it would be better to say "add functions to retrieve device info", since you are not saying much with the current title. I have seen also that this is based on the SGL code, so this patch didn't apply cleanly. Next time, specify it in the email the dependencies of the patch. Thanks, Pablo
