Hi Jingjing, Qi,
> -----Original Message----- > From: Wu, Jingjing > Sent: Friday, January 6, 2017 9:25 AM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Zhang, Qi Z > Subject: RE: [dpdk-dev] [PATCH v7 25/27] net/i40e: set/clear VF stats from PF > > > > > -----Original Message----- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > > Sent: Tuesday, January 3, 2017 2:55 PM > > To: dev@dpdk.org > > Cc: Zhang, Qi Z <qi.z.zh...@intel.com> > > Subject: [dpdk-dev] [PATCH v7 25/27] net/i40e: set/clear VF stats from > > PF > > > > From: Qi Zhang <qi.z.zh...@intel.com> > > > > This patch add support to get/clear VF statistics from PF side. > > Two APIs are added: > > rte_pmd_i40e_get_vf_stats. > > rte_pmd_i40e_reset_vf_stats. > > > > Signed-off-by: Qi Zhang <qi.z.zh...@intel.com> > > --- > > drivers/net/i40e/i40e_ethdev.c | 81 > > +++++++++++++++++++++++++++++++ > > drivers/net/i40e/rte_pmd_i40e.h | 41 ++++++++++++++++ > > drivers/net/i40e/rte_pmd_i40e_version.map | 2 + > > 3 files changed, 124 insertions(+) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > b/drivers/net/i40e/i40e_ethdev.c index 47e03d6..be45cfa 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -10480,3 +10480,84 @@ int rte_pmd_i40e_set_vf_vlan_filter(uint8_t > > port, uint16_t vlan_id, > > > > return ret; > > } > > + > > +int > > +rte_pmd_i40e_get_vf_stats(uint8_t port, > > + uint16_t vf_id, > > + struct rte_eth_stats *stats) > > +{ > > + struct rte_eth_dev *dev; > > + struct rte_eth_dev_info dev_info; > > + struct i40e_pf *pf; > > + struct i40e_vsi *vsi; > > + int ret = 0; > > + > > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); > > + > > + dev = &rte_eth_devices[port]; > > + rte_eth_dev_info_get(port, &dev_info); > > + > > + if (vf_id >= dev_info.max_vfs) > > + return -EINVAL; > > + > > + pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private); > > + > > + if (vf_id > pf->vf_num - 1 || !pf->vfs) { > > + PMD_DRV_LOG(ERR, "Invalid argument."); > > + return -EINVAL; > > + } > > + > > + vsi = pf->vfs[vf_id].vsi; > > + if (!vsi) > > + return -EINVAL; > > + > > + i40e_update_vsi_stats(vsi); > > + > > + stats->ipackets = vsi->eth_stats.rx_unicast + > > + vsi->eth_stats.rx_multicast + > > + vsi->eth_stats.rx_broadcast; > > + stats->opackets = vsi->eth_stats.tx_unicast + > > + vsi->eth_stats.tx_multicast + > > + vsi->eth_stats.tx_broadcast; > > + stats->ibytes = vsi->eth_stats.rx_bytes; > > + stats->obytes = vsi->eth_stats.tx_bytes; > > + stats->ierrors = vsi->eth_stats.rx_discards; > > + stats->oerrors = vsi->eth_stats.tx_errors + > > +vsi->eth_stats.tx_discards; > > + > > + return ret; > > It looks ret is not changed in this func at all. > > > +} > > + > > +int > > +rte_pmd_i40e_reset_vf_stats(uint8_t port, > > + uint16_t vf_id) > > +{ > > + struct rte_eth_dev *dev; > > + struct rte_eth_dev_info dev_info; > > + struct i40e_pf *pf; > > + struct i40e_vsi *vsi; > > + int ret = 0; > > + > > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); > > + > > + dev = &rte_eth_devices[port]; > > + rte_eth_dev_info_get(port, &dev_info); > > + > > + if (vf_id >= dev_info.max_vfs) > > + return -EINVAL; > > + > > + pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private); > > + > > + if (vf_id > pf->vf_num - 1 || !pf->vfs) { > > + PMD_DRV_LOG(ERR, "Invalid argument."); > > + return -EINVAL; > > + } > > + > > + vsi = pf->vfs[vf_id].vsi; > > + if (!vsi) > > + return -EINVAL; > > + > > + vsi->offset_loaded = false; > > + i40e_update_vsi_stats(vsi); > > + > > + return ret; > Same comment as above. I'll change it to 'return 0'. The same as above.
