> -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan....@linux.intel.com] > Sent: Wednesday, January 4, 2017 3:23 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; step...@networkplumber.org > Subject: Re: [PATCH v2 5/9] net/virtio: setup rxq interrupts > > On Wed, Jan 04, 2017 at 02:56:50PM +0800, Tan, Jianfeng wrote: > > > > > > [...] > > >>+ > > >>+ if (virtio_queues_bind_intr(dev) < 0) { > > >>+ PMD_INIT_LOG(ERR, "Failed to bind queue/interrupt"); > > >>+ return -1; > > >You have to free intr_handle->intr_vec, otherwise, memory leak occurs. > > > > It's freed at dev_close(). Do you mean freeing and reallocating here? As > > The typical way is free the resources have been allocated when errors > happens. > > > nr_rx_queues is not a changeable value, I don't see the necessity here. I > > miss something? > > No. nb_rx_queues does change, when people reconfigure the queue > number. > However, the MAX queues the virito supports does not change. You could > use that number for allocation.
Oh yes. I will fix it. Thanks, Jianfeng > > --yliu
