On 12/27/2016 12:30 PM, Qiming Yang wrote:
> This patch add a new function ixgbe_fw_version_get.
> 
> Signed-off-by: Qiming Yang <qiming.y...@intel.com>

<...>

>  
>  static void
> +ixgbe_fw_version_get(struct rte_eth_dev *dev, __rte_unused u32 *fw_major,
> +     __rte_unused u32 *fw_minor, __rte_unused u32 *fw_patch, u32 *etrack_id)

This API at least provide major and minor fw versions I think. Isn't
there any kind of FW version information for ixgbe? Just providing
etrack_id is not looking good.

> +{
> +     struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> +     u16 eeprom_verh, eeprom_verl;
> +
> +     ixgbe_read_eeprom(hw, 0x2e, &eeprom_verh);
> +     ixgbe_read_eeprom(hw, 0x2d, &eeprom_verl);
> +
> +     *etrack_id = (eeprom_verh << 16) | eeprom_verl;
> +}
> +
> +static void
>  ixgbe_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info 
> *dev_info)
>  {
>       struct rte_pci_device *pci_dev = IXGBE_DEV_TO_PCI(dev);
> 

Reply via email to