Hi Yuanhan,
On 12/26/2016 3:57 PM, Yuanhan Liu wrote:
On Mon, Dec 26, 2016 at 06:58:58AM +0000, Tan, Jianfeng wrote:
-----Original Message-----
From: Yuanhan Liu [mailto:yuanhan....@linux.intel.com]
Sent: Monday, December 26, 2016 2:28 PM
To: Tan, Jianfeng
Cc: dev@dpdk.org; Yigit, Ferruh; Liang, Cunming
Subject: Re: [PATCH v2 3/7] net/virtio_user: move vhost user specific code
On Fri, Dec 23, 2016 at 07:14:22AM +0000, Jianfeng Tan wrote:
To support vhost kernel as the backend of net_virtio_user in coming
patches, we move vhost_user specific structs and macros into
vhost_user.c, and only keep common definitions in vhost.h.
Good.
Besides, remove VHOST_USER_MQ feature check, it will be added back
in following multiqueue patch.
Why then?
Only vhost user recognizes this feature bit, and vhost kernel does not. My
intension is to put those vhost user specific code inside vhost user.
That's okay. But why you have to remove it and then add it back?
After second thought , I agree that it's necessary to add it back.
Currently, our vhost does not implement the semantics of
VHOST_USER_F_PROTOCOL_FEATURES.
Besides, all other comments from you on this patch series will be
addressed on next version. Thank you very much for those suggestions!
Thanks,
Jianfeng
--yliu
And in fact, I forget to add it back. I should add it back in this patch.
Thanks,
Jianfeng
--yliu
