> -----Original Message----- > From: Bie, Tiwei > Sent: Wednesday, December 28, 2016 3:01 PM > To: Xing, Beilei <beilei.x...@intel.com> > Cc: Wu, Jingjing <jingjing...@intel.com>; Zhang, Helin > <helin.zh...@intel.com>; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 15/17] net/i40e: add flow flush function > > On Wed, Dec 28, 2016 at 02:48:02PM +0800, Xing, Beilei wrote: > > > -----Original Message----- > > > From: Bie, Tiwei > > > Sent: Wednesday, December 28, 2016 1:36 PM > > > To: Xing, Beilei <beilei.x...@intel.com> > > > Cc: Wu, Jingjing <jingjing...@intel.com>; Zhang, Helin > > > <helin.zh...@intel.com>; dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v2 15/17] net/i40e: add flow flush > > > function > > > > > > On Tue, Dec 27, 2016 at 02:26:22PM +0800, Beilei Xing wrote: > > > > This patch adds i40e_flow_flush function to flush all filters for > > > > users. And flow director flush function is involved first. > > > > > > > > Signed-off-by: Beilei Xing <beilei.x...@intel.com> > > > > --- > > > > drivers/net/i40e/i40e_ethdev.h | 3 +++ > > > > drivers/net/i40e/i40e_fdir.c | 8 ++------ > > > > drivers/net/i40e/i40e_flow.c | 46 > > > ++++++++++++++++++++++++++++++++++++++++++ > > > > 3 files changed, 51 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.h > > > > b/drivers/net/i40e/i40e_ethdev.h index b8c7d41..0b736d5 100644 > > > > --- a/drivers/net/i40e/i40e_ethdev.h > > > > +++ b/drivers/net/i40e/i40e_ethdev.h > > > > @@ -786,6 +786,9 @@ i40e_sw_tunnel_filter_lookup(struct > > > i40e_tunnel_rule *tunnel_rule, > > > > const struct i40e_tunnel_filter_input > > > > *input); int > > > > i40e_sw_tunnel_filter_del(struct i40e_pf *pf, > > > > struct i40e_tunnel_filter *tunnel_filter); > > > > +int i40e_sw_fdir_filter_del(struct i40e_pf *pf, > > > > + struct i40e_fdir_filter *filter); int > > > i40e_fdir_flush(struct > > > > +rte_eth_dev *dev); > > > > > > > > > > Why don't declare them as the global functions at the beginning? > > > > When I implement the store/restore function, I plan this function is only > used in i40e_ethdev.c. > > I change them to the global functions since I add i40e_flow.c to rework all > the flow ops. > > > > These functions are also introduced in this patch set. There is no particular > reason to mark them as static at first and then turn them into the global > functions in the later patches. So it would be better to declare them as the > global ones when introducing them.
Yes, make sense. Will update in next version. > > Best regards, > Tiwei Bie
