Hi Qiming,
> -----Original Message-----
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang
> Sent: Friday, December 23, 2016 5:32 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing...@intel.com>; Yang, Qiming
> <qiming.y...@intel.com>
> Subject: [dpdk-dev] [PATCH v4] app/testpmd: supported offload capabilities
> query
>
> Add two new commands "show port cap <port>" and "show port cap all"to
> diaplay what offload capabilities supported in ports. It will not only
> display all
> the capabilities of the port, but also the enabling condition for each
> capability in
> the running time.
>
> Signed-off-by: Qiming Yang <qiming.y...@intel.com>
> ---
> v2 changes:
> * fixed the output style as Ferruh's patch show and add some
> description in docs for new functions.
> v3 changes:
> * add new command in cmd_help_long_parsed.
> v4 changes:
> * use 'cap' instead of 'capa'.
> ---
> ---
> app/test-pmd/cmdline.c | 17 ++-
> app/test-pmd/config.c | 172
> ++++++++++++++++++++++++++++
> app/test-pmd/testpmd.h | 1 +
> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +-
> 4 files changed, 192 insertions(+), 10 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> 63b55dc..bbfafab 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> +
> + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_TCP_CKSUM) {
> + printf("TCP checksum: ");
> + if (dev->data->dev_conf.rxmode.hw_ip_checksum)
> + printf("on\n");
> + else
> + printf("off\n");
> + }
> +
> + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_TCP_LRO) {
> + printf("Large receive offload: ");
> + if (dev->data->dev_conf.rxmode.enable_lro)
> + printf("on\n");
> + else
> + printf("off\n");
> + }
> +
> + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_QINQ_STRIP) {
> + printf("Double VLANs stripped: ");
> + if (dev->data->dev_conf.rxmode.hw_vlan_extend)
> + printf("on\n");
> + else
> + printf("off\n");
> + }
> +
> + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM)
> + printf("Outer IPv4 checksum: ");
Seems there's no 'on' or 'off' printed here, do I miss anything?
> +
> + if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_VLAN_INSERT) {
> + printf("VLAN insert: ");
> + if (ports[port_id].tx_ol_flags &
> TESTPMD_TX_OFFLOAD_INSERT_VLAN)
> + printf("on\n");
> + else
> + printf("off\n");
> + }
> +
