Hi Alejandro, On 12/19/2016 12:05 PM, Alejandro Lucero wrote: > NFP supports more speeds than just 40 and 100GB, which were > what was advertised before. > > Signed-off-by: Alejandro Lucero <alejandro.luc...@netronome.com> > --- > drivers/net/nfp/nfp_net.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > index 27afbfd..77015c4 100644 > --- a/drivers/net/nfp/nfp_net.c > +++ b/drivers/net/nfp/nfp_net.c > @@ -1077,7 +1077,9 @@ static void nfp_net_read_mac(struct nfp_net_hw *hw) > dev_info->reta_size = NFP_NET_CFG_RSS_ITBL_SZ; > dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ; > > - dev_info->speed_capa = ETH_LINK_SPEED_40G | ETH_LINK_SPEED_100G; > + dev_info->speed_capa = ETH_SPEED_NUM_1G | ETH_LINK_SPEED_10G | > + ETH_SPEED_NUM_25G | ETH_SPEED_NUM_40G | > + ETH_SPEED_NUM_50G | ETH_LINK_SPEED_100G;
Does all devices driver by this driver supports all these speeds? I am aware of at least one exception to this, from previous patch [1], should we take that into account? Also other than that exception, can you please confirm all other devices support all above speeds? [1] + if ((NFD_CFG_MAJOR_VERSION_of(hw->ver) < 4) || + ((NFD_CFG_MINOR_VERSION_of(hw->ver) == 4) && + (NFD_CFG_MINOR_VERSION_of(hw->ver) == 0))) + link.link_speed = ETH_SPEED_NUM_40G; > } > > static const uint32_t * >
