/build/lib/librte_eal/linuxapp/kni/igb_main.c:2317:21: error: initialization 
from incompatible pointer type [-Werror=incompatible-pointer-types]
  .ndo_set_vf_vlan = igb_ndo_set_vf_vlan,
                     ^~~~~~~~~~~~~~~~~~~

I am sure Ferruh Yigit will fix it.

Which raises a couple of questions:
 1. Why is DPDK still keeping KNI support for Intel specific ethtool 
functionality.
    This always breaks, is code bloat, and means a 3rd copy of base code 
(Linux, DPDK PMD, + KNI)

 2. Why is KNI not upstream?
    If not acceptable due to security or supportablity then why does it still 
exist?

 3. If not upstream, then maintainer should track upstream kernel changes and 
fix DPDK before
    kernel is released.  The ABI is normally set early in the rc cycle weeks 
before release.

Reply via email to