On 07/12/16 20:09, Thomas Monjalon wrote:
2016-12-07 20:04, Zbigniew Bodek:
On 06.12.2016 21:27, Thomas Monjalon wrote:
2016-12-06 18:32, zbigniew.bo...@caviumnetworks.com:
From: Zbigniew Bodek <zbigniew.bo...@caviumnetworks.com>
Add type and name for ARMv8 crypto PMD
Signed-off-by: Zbigniew Bodek <zbigniew.bo...@caviumnetworks.com>
[...]
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -66,6 +66,8 @@
/**< KASUMI PMD device name */
#define CRYPTODEV_NAME_ZUC_PMD crypto_zuc
/**< KASUMI PMD device name */
+#define CRYPTODEV_NAME_ARMV8_PMD crypto_armv8
+/**< ARMv8 CM device name */
/** Crypto device type */
enum rte_cryptodev_type {
@@ -77,6 +79,7 @@ enum rte_cryptodev_type {
RTE_CRYPTODEV_KASUMI_PMD, /**< KASUMI PMD */
RTE_CRYPTODEV_ZUC_PMD, /**< ZUC PMD */
RTE_CRYPTODEV_OPENSSL_PMD, /**< OpenSSL PMD */
+ RTE_CRYPTODEV_ARMV8_PMD, /**< ARMv8 crypto PMD */
};
Can we remove all these types and names in the generic crypto API?
Hello Thomas,
I added another PMD type and therefore we need new, unique number for
it. I'm not sure if I understand correctly what you mean here, so please
elaborate.
My comment is not specific to your PMD.
I think there is something wrong in the design of cryptodev if we need
to update rte_cryptodev.h each time a new driver is added.
There is no such thing in ethdev.
Hey Thomas, I've been meaning to have a look at removing this enum, I
just haven't had the time as yet, I think since there is now a standard
naming convention for all pmds, the use for this is redundant.
This change will require a ABI/API deprecation notice, so I'll put that
into 17.02 and then do the patches to remove for 17.05
Declan
