[dpdk-dev] [PATCH v2 32/32] app/testpmd: fix invalid port ID

[Wenzhuo Lu]

Some CLIs don't check the input port ID, it
may cause segmentation fault (core dumped).

Fixes: 425781ff5afe ("app/testpmd: add ixgbe VF management")

Signed-off-by: Wenzhuo Lu <wenzhuo...@intel.com>
Signed-off-by: Chen Jing D(Mark) <jing.d.c...@intel.com>
---
 app/test-pmd/cmdline.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index e1a7e02..be0c424 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -10829,6 +10829,9 @@ struct cmd_vf_vlan_anti_spoof_result {
        int is_on = (strcmp(res->on_off, "on") == 0) ? 1 : 0;
        struct rte_eth_dev_info dev_info;
 
+       if (port_id_is_invalid(res->port_id, ENABLED_WARN))
+               return;
+
        memset(&dev_info, 0, sizeof(dev_info));
        rte_eth_dev_info_get(res->port_id, &dev_info);
 
@@ -10930,6 +10933,9 @@ struct cmd_vf_mac_anti_spoof_result {
        int is_on = (strcmp(res->on_off, "on") == 0) ? 1 : 0;
        struct rte_eth_dev_info dev_info;
 
+       if (port_id_is_invalid(res->port_id, ENABLED_WARN))
+               return;
+
        memset(&dev_info, 0, sizeof(dev_info));
        rte_eth_dev_info_get(res->port_id, &dev_info);
 
@@ -11031,6 +11037,9 @@ struct cmd_vf_vlan_stripq_result {
        int is_on = (strcmp(res->on_off, "on") == 0) ? 1 : 0;
        struct rte_eth_dev_info dev_info;
 
+       if (port_id_is_invalid(res->port_id, ENABLED_WARN))
+               return;
+
        memset(&dev_info, 0, sizeof(dev_info));
        rte_eth_dev_info_get(res->port_id, &dev_info);
 
@@ -11129,6 +11138,9 @@ struct cmd_vf_vlan_insert_result {
        int ret;
        struct rte_eth_dev_info dev_info;
 
+       if (port_id_is_invalid(res->port_id, ENABLED_WARN))
+               return;
+
        memset(&dev_info, 0, sizeof(dev_info));
        rte_eth_dev_info_get(res->port_id, &dev_info);
 
@@ -11218,6 +11230,9 @@ struct cmd_tx_loopback_result {
        int is_on = (strcmp(res->on_off, "on") == 0) ? 1 : 0;
        struct rte_eth_dev_info dev_info;
 
+       if (port_id_is_invalid(res->port_id, ENABLED_WARN))
+               return;
+
        memset(&dev_info, 0, sizeof(dev_info));
        rte_eth_dev_info_get(res->port_id, &dev_info);
 
@@ -11307,6 +11322,9 @@ struct cmd_all_queues_drop_en_result {
        int ret = 0;
        int is_on = (strcmp(res->on_off, "on") == 0) ? 1 : 0;
 
+       if (port_id_is_invalid(res->port_id, ENABLED_WARN))
+               return;
+
        ret = rte_pmd_ixgbe_set_all_queues_drop_en(res->port_id, is_on);
        switch (ret) {
        case 0:
@@ -11390,6 +11408,9 @@ struct cmd_vf_split_drop_en_result {
        int ret;
        int is_on = (strcmp(res->on_off, "on") == 0) ? 1 : 0;
 
+       if (port_id_is_invalid(res->port_id, ENABLED_WARN))
+               return;
+
        ret = rte_pmd_ixgbe_set_vf_split_drop_en(res->port_id, res->vf_id,
                        is_on);
        switch (ret) {
@@ -11474,6 +11495,9 @@ struct cmd_set_vf_mac_addr_result {
        struct cmd_set_vf_mac_addr_result *res = parsed_result;
        int ret;
 
+       if (port_id_is_invalid(res->port_id, ENABLED_WARN))
+               return;
+
        ret = rte_pmd_ixgbe_set_vf_mac_addr(res->port_id, res->vf_id,
                        &res->mac_addr);
        switch (ret) {
-- 
1.9.3