Hi Chas,
On 9/29/2016 11:20 AM, Chas Williams wrote:
> Correctly hint the cache line size. Remove unused macros associated
> with the cache line size.
>
> Fixes: 540a211084a7 ("bnx2x: driver core")
>
> Signed-off-by: Chas Williams <3chas3 at gmail.com>
> Acked-by: Harish Patil <harish.patil at qlogic.com>
> ---
Thank you for the updated patch.
When sending next version of the patchset, can you please take care of
following too:
- patch title should be:
"net/<driver>: all_lowercase_except_abbreviations"
so this patch subject becomes:
"net/bnx2x: set cache line based on build configuration"
- Rx/Tx should not be used as "RX" or "rx" in patch title
- There are three checkpatch warnings of same type on patch 10/10:
CHECK:SPACING: No space is necessary after a cast
#105: FILE: drivers/net/bnx2x/bnx2x.h:1461:
+ ((uintptr_t) sc->bar[BAR0].base_addr + offset)));
- Is ack from Harish for this patch only or for all patchset? Since this
patchset doesn't have a cover letter, if ack is for patchset please put
Acked-by line to each patch.
Thanks,
ferruh
