On 9/22/2016 6:44 AM, Jianfeng Tan wrote: > In igb_uio, iomem is mapped, and both ioport and io mem are recorded > into uio framework (then into sysfs files), which is duplicated with > what Linux has already provided for user space, and makes the code > too complex. > > For iomem, DPDK user space code never opens or reads files under > /sys/pci/bus/devices/xxxx:xx:xx.x/uio/uioY/maps/. Instead, > /sys/pci/bus/devices/xxxx:xx:xx.x/resourceY are used to map device > memory. > > For ioport, non-x86 platforms cannot read from files under > /sys/pci/bus/devices/xxxx:xx:xx.x/uio/uioY/portio/ directly, because > non-x86 platforms need to map port region for access in user space, > see non-x86 version pci_uio_ioport_map(). x86 platforms can use the > the same way as uio_pci_generic. > > This will remove iomem and ioport mapping in igb_uio kernel module, > and adjusts the iomem implementation in both igb_uio and > uio_pci_generic: > - for x86 platform, get ports info from /proc/ioports; > - for non-x86 platform, map and get ports info by pci_uio_ioport_map(). > > Note: this will affect those applications who are using files under > /sys/pci/bus/devices/xxxx:xx:xx.x/uio/uioY/maps/ and > /sys/pci/bus/devices/xxxx:xx:xx.x/uio/uioY/portio/. > > Suggested-by: Yigit, Ferruh <ferruh.yigit at intel.com> > Signed-off-by: Jianfeng Tan <jianfeng.tan at intel.com> > ---
Acked-by: Ferruh Yigit <ferruh.yigit at intel.com>
