On Wed, Sep 28, 2016 at 11:05:19AM +0100, Ferruh Yigit wrote:
> Compile error:
> CC mlx5.o.pmd.o
> mlx5.o.pmd.c:1:227:
> error: no newline at end of file [-Werror,-Wnewline-eof]
> ...__attribute__((used)) = "PMD_INFO_STRING= {...}";
> ^
>
> Produced with clang 3.8.0 and MLX5_PMD and MLX5_DEBUG
> config options enabled.
>
> Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> ---
> buildtools/pmdinfogen/pmdinfogen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/buildtools/pmdinfogen/pmdinfogen.c
> b/buildtools/pmdinfogen/pmdinfogen.c
> index e1bf2e4..59ab956 100644
> --- a/buildtools/pmdinfogen/pmdinfogen.c
> +++ b/buildtools/pmdinfogen/pmdinfogen.c
> @@ -386,7 +386,7 @@ static void output_pmd_info_string(struct elf_info *info,
> char *outfile)
> else
> fprintf(ofd, " ");
> }
> - fprintf(ofd, "]}\";");
> + fprintf(ofd, "]}\";\n");
> drv = drv->next;
> }
>
> --
> 2.7.4
>
>
What was the error this produced? It seems like a false positive to me to
require a newline at the end of a string, and it certainly doesn't provide any
benefit when pmdinfo reads it back later.
Neil
