Hi,
> -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Marcin Kerlin > Sent: Tuesday, September 27, 2016 12:13 PM > To: dev at dpdk.org > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; > thomas.monjalon at 6wind.com; Kerlin, MarcinX <marcinx.kerlin at intel.com> > /** > * @internal > + * Returns a shared device data slot specified by the unique identifier name. > + * > + * @param name > + * The pointer to the Unique identifier name for each shared Ethernet > +device > + * between multiple processes. > + * @return > + * - The pointer to the shared ethdev slot, on success. NULL on error > + */ > +struct rte_eth_dev_data *rte_eth_dev_data_allocated(const char *name); > + 1) You forgot to remove this function declaration. 2)Check patch reported lines over 80 characters. Please run check patch on next versions of patch before sending. WARNING:LONG_LINE_STRING: line over 80 characters #106: FILE: lib/librte_ether/rte_ethdev.c:258: + RTE_PMD_DEBUG_TRACE("Reached maximum number of Ethernet ports by all " WARNING:LONG_LINE_STRING: line over 80 characters #118: FILE: lib/librte_ether/rte_ethdev.c:270: + RTE_PMD_DEBUG_TRACE("Ethernet Device with name %s already allocated by " WARNING:LONG_LINE: line over 80 characters #151: FILE: lib/librte_ether/rte_ethdev.c:503: + if (!strncmp(name, rte_eth_devices[i].data->name, strlen(name))) { 3)Can you also make sure to rebase when you send next patch version, as I see some issue while applying the patch Applying: librte_ether: add protection against overwrite device data error: lib/librte_ether/rte_ether_version.map: does not match index Patch failed at 0001 librte_ether: add protection against overwrite device data Thanks, Reshma
