On Thu, 22 Sep 2016 00:08:38 +0000 "Dey, Souvik" <sodey at sonusnet.com> wrote:
> I am fine with the general idea of this patch but: > 1. Calling virtio_dev_info_get is needlessly wasteful when all you want > is to access the max packet length. Since max_rx_pktlen is always > VIRTIO_MAX_RX_PKTLEN, please just use that. > [Dey, Souvik] I am using the virtio_dev_info_get as in future can/may support > the max_rx_pktlen as a variable to be set by the application. This will keep > the changes future proof. As we need to support till 65535 instead of 9728 as > the linux does. Future proof is a myth. Don't add code based on planned future functionality http://www.extremeprogramming.org/rules/early.html
