Hi Reshma, > -----Original Message----- > From: Pattan, Reshma > Sent: Tuesday, September 20, 2016 6:14 PM > To: Kerlin, MarcinX <marcinx.kerlin at intel.com>; dev at dpdk.org > Cc: thomas.monjalon at 6wind.com; De Lara Guarch, Pablo > <pablo.de.lara.guarch at intel.com>; Kerlin, MarcinX > <marcinx.kerlin at intel.com> > Subject: RE: [dpdk-dev] [PATCH v2 1/2] librte_ether: ensure not overwrite > device data in mp app > > Hi Marcin, > > > > > /** > > * @internal > > + * Returns a shared device data slot specified by the unique identifier > > name. > > + * > > + * @param name > > + * The pointer to the Unique identifier name for each shared > > +Ethernet device > > + * between multiple processes. > > + * @return > > + * - The pointer to the device data slot, on success. NULL on error > > + */ > > +struct rte_eth_dev_data *rte_eth_dev_data_allocated(const char > > +*name); > > This should be static function in source file rather than public function. > And name can be rte_eth_dev_get_dev_by_name() something like that?
1) Yes should be, this function is not using outside lib now, thanks 2) My proposition is rte_eth_dev_get_dev_data_by_name(), because it is related with device data structure.. Do you have any objections Thomas? I am waiting for still some objections and then prepare v3 Regards, Marcin > > Thanks, > Reshma
