hi, yuanhan: > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Wednesday, September 21, 2016 6:57 PM > To: Yang, Zhiyong <zhiyong.yang at intel.com> > Cc: dev at dpdk.org; Van Haaren, Harry <harry.van.haaren at intel.com>; > thomas.monjalon at 6wind.com; pmatilai at redhat.com > Subject: Re: [PATCH v4 2/2] net/vhost: add pmd xstats > > On Wed, Sep 21, 2016 at 06:05:55PM +0800, Zhiyong Yang wrote: > > +static inline void > > +vhost_count_multicast_broadcast(struct vhost_queue *vq, > > + struct rte_mbuf **bufs, > > + uint16_t count) > > Hmm.. why not just passing "struct rte_mbuf *mbuf"? >
Passing "struct rte_mbuf *mbuf" can reduce one parameter. But the function is small and frequently invoked. So, I define it as the inline function, I think the two types of definitions should have the same performance for inline function. Should I modify it in next patch? --zhiyong > --yliu