On 8/27/2016 4:48 PM, Xiao Wang wrote:
> This patch makes sure that we access IOSF registers through the HIC
> (host interface command) for the majority of X550em devices. All devices
> with NVM are capable of using the HIC.
>
> For consistency all instances where the ixgbe_read/write_iosf_sb_reg_x550
> is called directly are converted to function pointer calls.
>
> Signed-off-by: Xiao Wang <xiao.w.wang at intel.com>
> ---
> drivers/net/ixgbe/base/ixgbe_phy.c | 2 +-
> drivers/net/ixgbe/base/ixgbe_x550.c | 38
> ++++++++++++++++++++++---------------
> 2 files changed, 24 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/net/ixgbe/base/ixgbe_phy.c
> b/drivers/net/ixgbe/base/ixgbe_phy.c
> index d33d0f8..ee8618f 100644
> --- a/drivers/net/ixgbe/base/ixgbe_phy.c
> +++ b/drivers/net/ixgbe/base/ixgbe_phy.c
> @@ -741,7 +741,7 @@ s32 ixgbe_write_phy_reg_generic(struct ixgbe_hw *hw, u32
> reg_addr,
> DEBUGFUNC("ixgbe_write_phy_reg_generic");
>
> if (hw->mac.ops.acquire_swfw_sync(hw, gssr) == IXGBE_SUCCESS) {
> - status = ixgbe_write_phy_reg_mdi(hw, reg_addr, device_type,
> + status = hw->phy.ops.write_reg_mdi(hw, reg_addr, device_type,
> phy_data);
Is this IOSF register?
...
> @@ -4504,7 +4512,7 @@ s32 ixgbe_write_phy_reg_x550a(struct ixgbe_hw *hw, u32
> reg_addr,
> DEBUGFUNC("ixgbe_write_phy_reg_x550a");
>
> if (hw->mac.ops.acquire_swfw_sync(hw, mask) == IXGBE_SUCCESS) {
> - status = ixgbe_write_phy_reg_mdi(hw, reg_addr, device_type,
> + status = hw->phy.ops.write_reg_mdi(hw, reg_addr, device_type,
same question?
> phy_data);
> hw->mac.ops.release_swfw_sync(hw, mask);
> } else {
>
