On 08/25/2016 00:59, Nikita Kozlov wrote: > This serie of pathes focus on improving the speed of deleting rules in lpm6. > > It also contains some other improvement like having a dynamic number of > rules in lpm6 and increasing the lpm6 nexthop size to 16bit for matching > the nexthop size in lpm4. > > The performances improvement can be seen by running test_lpm6_perf but > because of the limited number of rules added (1000) the improvement seen is > just about a x10 with this test. > > For testing it further we have tested it with a full ipv6 bgp view which > represent 29296 routes in our test: > * With the dpdk 16.04 it tooks an average of 8.46095e+09 cycles to delete a > rule > (calculated with mesuring rte_rdtsc before and after the delete, the > average is calculated by the first 10 delete, it represents several > seconds on a E5-2650 v2) > * With the patch it tooks 10077.1 cycles (same number of deleted rules, > same machine, same rules inserted) for the same test. > > This patch was written in collaboration with Baptiste Daroussin from Gandi. > > Changes since V1: > - use system bsd-tree.h > - fix a bug when valid_group field was overwritten > > Nikita Kozlov (2): > lpm6: speed inmprovement on delete rule > test_lpm6: make test_lpm6* compatible with the new rte_lpm6.c lib > > app/test/test_lpm6.c | 244 +++++-------- > app/test/test_lpm6_perf.c | 6 +- > lib/librte_lpm/Makefile | 2 +- > lib/librte_lpm/rte_lpm6.c | 626 > +++++++++++++++++++++++++--------- > lib/librte_lpm/rte_lpm6.h | 50 ++- > lib/librte_lpm/rte_lpm_version.map | 12 + > lib/librte_table/rte_table_lpm_ipv6.c | 7 +- > 7 files changed, 609 insertions(+), 338 deletions(-) > Hello, If someone have some time, I feel that this patch needs some polishing so any comments on the code are more than welcome, even if they are not directly related to the lpm part itself.
thanks.
