Hi Maxime,
In that case let this fix be there till the time the new implementation
comes in. We can re-visit the changes again in the new implementation and then
decide to keep this or remove it. Hope this serves all the purposes.
--
Regards,
Souvik
-----Original Message-----
From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
Sent: Friday, September 2, 2016 3:06 AM
To: Dey, Souvik <sodey at sonusnet.com>; stephen at networkplumber.org
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] add mtu set in virtio
Hi Souvik,
On 09/02/2016 12:20 AM, Dey, Souvik wrote:
> Hi Maxime,
> When is patches or new implementation going to come in the release ? if
> it is not 16.11 then, can we keep this change till the new virtio changes
> come in the release. And if it is already planned for 16.11, then can I get a
> little more information on that.
>
I'm currently working on qemu part implementation, first RFC should be sent
next week.
Goal is to have it in 16.11, but I cannot commit, as the spec update has not
been acked yet.
For more information, you can start by having a look at the spec review:
https://lists.oasis-open.org/archives/virtio-dev/201608/msg00056.html
Regards,
Maxime
> --
> Regards,
> Souvik
>
> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com]
> Sent: Tuesday, August 30, 2016 3:58 AM
> To: Dey, Souvik <sodey at sonusnet.com>; stephen at networkplumber.org;
> huawei.xie at intel.com; yuanhan.liu at linux.intel.com
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] add mtu set in virtio
>
> Hi Souvik,
>
> On 08/30/2016 01:02 AM, souvikdey33 wrote:
>> Signed-off-by: Souvik Dey <sodey at sonusnet.com>
>>
>> Fixes: 1fb8e8896ca8 ("Signed-off-by: Souvik Dey
>> <sodey at sonusnet.com>")
>> Reviewed-by: Stephen Hemminger <stephen at networkplumber.org>
>>
>> Virtio interfaces should also support setting of mtu, as in case of
>> cloud it is expected to have the consistent mtu across the
>> infrastructure that the dhcp server sends and not hardcoded to 1500(default).
>> ---
>> drivers/net/virtio/virtio_ethdev.c | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>
> FYI, there are some on-going changes in the VIRTIO specification so that the
> VHOST interface exposes its MTU to its VIRTIO peer.
> It may also be used as an alternative of what you patch achieves.
>
> I am working on its implementation in Qemu/DPDK, our goal being to reduce
> performance drops for small packets with Rx mergeable buffers feature enabled.
>
> Regards,
> Maxime
>
