Hello Ferruh, On Wednesday 26 October 2016 07:55 PM, Ferruh Yigit wrote: > Hi Shreyansh, > > On 10/26/2016 2:12 PM, Shreyansh Jain wrote: >> On Wednesday 26 October 2016 06:30 PM, Shreyansh Jain wrote: >>> rte_device/driver generalization patches [1] were merged without a change >>> in the LIBABIVER macro. This patches bumps the macro of affected libs. >>> >>> Also, deprecation notice from 16.07 has been removed and release notes for >>> 16.11 added. >>> >>> Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com> >>> -- >>> v2: >>> - Mark bumped libraries in release_16_11.rst file >>> - change code symbol names from text to code layout >>> >>> --- > > <...> > >>> .. code-block:: diff >>> >>> - libethdev.so.4 >>> + + libethdev.so.4 >> >> Just noticed: >> Should the '4' here reflect the current LIBABIVER number? >> If so, I will send this patch again. > > Yes, as you guessed, it should be: > - libethdev.so.4 > + + libethdev.so.5 > > <...> > >>> diff --git a/lib/librte_eal/bsdapp/eal/Makefile >>> b/lib/librte_eal/bsdapp/eal/Makefile >>> index a15b762..122798c 100644 >>> --- a/lib/librte_eal/bsdapp/eal/Makefile >>> +++ b/lib/librte_eal/bsdapp/eal/Makefile >>> @@ -48,7 +48,7 @@ LDLIBS += -lgcc_s >>> >>> EXPORT_MAP := rte_eal_version.map >>> >>> -LIBABIVER := 3 >>> +LIBABIVER := 4 > > eal version seems already increased for this release, 2 => 3, in: > d7e61ad3ae36 ("log: remove deprecated history dump") > > So NO need to increase it again, sorry for late notice, I just > recognized it. > Only librte_ether and librte_cryptodev requires the increase.
Thanks for clearing this. I will bump librte_ether and librte_cryptodev and send across v3. > > <...> > > Thanks, > ferruh > > The LIBABI check script is really helpful. I wish I had run that for rte_driver/device patchset. Thanks for that info, though. - Shreyansh