On 2016?10?11? 12:14, Yuanhan Liu wrote: > On Fri, Oct 07, 2016 at 07:24:44AM +0300, Michael S. Tsirkin wrote: >> On Wed, Sep 28, 2016 at 04:25:12PM +0800, Jason Wang wrote: >>> Negotiate VIRTIO_F_IOMMU_PLATFORM to have IOMMU support. >>> >>> Signed-off-by: Jason Wang <jasowang at redhat.com> >>> --- >>> Changes from v1: >>> - remove unnecessary NEED_MAPPING flag >> One thing we probably should do is enable this flag >> with VFIO but not with UIO or VFIO-noiommu. > Good suggestion. I think we could do that in another patch.
Yes. > >>> --- >>> drivers/net/virtio/virtio_ethdev.h | 3 ++- >>> drivers/net/virtio/virtio_pci.h | 3 ++- >>> 2 files changed, 4 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/net/virtio/virtio_ethdev.h >>> b/drivers/net/virtio/virtio_ethdev.h >>> index 2ecec6e..04a06e2 100644 >>> --- a/drivers/net/virtio/virtio_ethdev.h >>> +++ b/drivers/net/virtio/virtio_ethdev.h >>> @@ -63,7 +63,8 @@ >>> 1u << VIRTIO_NET_F_CTRL_RX | \ >>> 1u << VIRTIO_NET_F_CTRL_VLAN | \ >>> 1u << VIRTIO_NET_F_MRG_RXBUF | \ >>> - 1ULL << VIRTIO_F_VERSION_1) >>> + 1ULL << VIRTIO_F_VERSION_1 | \ >>> + 1ULL << VIRTIO_F_IOMMU_PLATFORM ) >> Space before ) looks kind of ugly. > Yes, a bit. I will remove it while apply. > >>> #define VIRTIO_TRANSPORT_F_START 28 >>> -#define VIRTIO_TRANSPORT_F_END 32 >>> +#define VIRTIO_TRANSPORT_F_END 34 >>> >> This seems unused. Drop it? > Indeed. I will submit a patch to remove both (_START and _END). > > --yliu Thanks
