On Wed, 19 Oct 2016, Lu, Wenzhuo wrote:
> Hi Scott, > >> -----Original Message----- >> From: Scott Daniels [mailto:daniels at research.att.com] >> Sent: Thursday, October 20, 2016 10:11 AM >> To: Lu, Wenzhuo >> Cc: Zhang, Helin; Iremonger, Bernard; dev at dpdk.org; ZELEZNIAK, ALEX >> Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: prevent duplicate callback on list >> >> >> >> On Wed, 19 Oct 2016, Lu, Wenzhuo wrote: >> >>> Hi Scott, >>> >>>> -----Original Message----- >>>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of E. Scott Daniels >>>> Sent: Thursday, October 20, 2016 6:23 AM >>>> To: Zhang, Helin; Iremonger, Bernard >>>> Cc: dev at dpdk.org; az5157 at att.com; E. Scott Daniels >>>> Subject: [dpdk-dev] [PATCH] net/ixgbe: prevent duplicate callback on >>>> list >>>> >>>> This change prevents the attempt to add a structure which is already >>>> on the callback list. If a struct with matching parameters is found >>>> on the list, then no action is taken. If a struct with matching >>>> parameters is found on the list, then no action is taken. >>>> >>>> Signed-off-by: E. Scott Daniels <daniels at research.att.com> >>> I think the fix itself is good. But 2 things, 1, normally we don't >>> create a cover letter for a patch set which only has one patch. Just >>> sending the >> patch itself is enough. >>> 2, ' net/ixgbe: ' in the title is used to describe the component. So the >>> title >> should be ' lib/ether: prevent duplicate callback on list'. >>> Thanks. >> >> Thanks for the advice. My mistake on the component. Is there an easy way to >> fix, or does it make sense just to nack this and I'll submit one with the >> correct >> component. > No need to NACK it. You can send a V2 with the correct component. And I think > you can add my ack in the V2. > Acked-by: Wenzhuo Lu <Wenzhuo.lu at intel.com> > > BTW, I forgot to mention that as it's a fix. We always add a Fixes tag in the > commit log. You can find the example from other one's mails :) Will do. The patch checker was squaking about the fixes tag and I remvoed it :( So, I need to figure out what it didn't like about it and I'll fix with a V2 and add your ack. Getting late here tonight, so tomorrow. Thanks Scott > >> >> Scott >> >>> >>> >
