On Mon, Oct 10, 2016 at 03:16:09PM +0100, Mcnamara, John wrote: > > -----Original Message----- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John Daley > > Sent: Thursday, September 29, 2016 9:55 PM > > To: Richardson, Bruce <bruce.richardson at intel.com> > > Cc: dev at dpdk.org; Nelson Escobar <neescoba at cisco.com> > > Subject: [dpdk-dev] [PATCH] net/enic: update enic guide and add warning > > for invalid conf > > > > From: Nelson Escobar <neescoba at cisco.com> > > > > Update the enic guide to better explain how to setup vNIC parameters on > > the Cisco VIC since the introduction of rx scatter and print an error > > message for the case of having 1 RQ configured in the vNIC. > > > > Signed-off-by: Nelson Escobar <neescoba at cisco.com> > > Hi, > > It would be better in the RST documentation to use ```` backticks to > designate function and variable names as fixed width. Also, the documentation > convention is to use Rx/Tx. However, these are minor so the patch is okay as > it is. > > Acked-by: John McNamara <john.mcnamara at intel.com> > Applied to dpdk-next-net/rel_16_11 as "document how to configure vNIC parameters" so as to make it clear that this is one logical change, rather than two - which would be implied by the use of "and" in the title.
/Bruce
