2016-10-11 14:46, John Ousterhout: > All of your suggestions look reasonable and fairly straightforward; I'll > work on a new patch that includes them. > > Given that rte_eal_log_init is a no-op (and won't even be invoked), would > it be better to remove that function completely, and even delete the file > containing it (eal_log.c), or is it better to retain the empty function in > order to maintain a parallel structure with Linux? Personally I'd lean > towards deleting the file. As it stands, the interface to that function > doesn't even make sense for BSD; the arguments were chosen for Linux and > are ignored in BSD. > > Let me know your preference.
Yes you can remove the file.
