Hi,
> From: Ajit Khaparde [mailto:ajit.khaparde at broadcom.com]
> Sent: Monday, October 10, 2016 11:41 AM
> To: Yigit, Ferruh
> Cc: dev at dpdk.org; De Lara Guarch, Pablo
> Subject: Re: [dpdk-dev] [PATCH 1/4] testpmd: Add support to configure 25G
> and 50G speeds
>
> On Mon, Oct 10, 2016 at 10:01 AM, Ferruh Yigit <ferruh.yigit at intel.com>
> wrote:
> Hi Ajit,
>
> On 9/29/2016 6:03 PM, Ajit Khaparde wrote:
> > Support to configure 25G and 50G speeds is missing from testpmd.
> > This patch also updates the testpmd user guide accordingly.
> >
> > Signed-off-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
>
> This patch seems not really part of the patchset for bnxt driver, but
> standalone testpmd only modification,
> ??
> and can be threaded as single patch.
> ?OK. Got it.
> I had worked on this change in the middle of other things.
> ?So it got bundled along with other bnxt patches.
>
>
> I am adding testpmd maintainer to cc.
> ?Let me know if you want me to send it again as a standalone patch.
Yes, I think it is a good idea.
Apart from that, there are a couple of things to fix:
There are two lines that exceed the character limit (from checkpatch):
WARNING: line over 80 characters
#55: FILE: app/test-pmd/cmdline.c:1084:
+ .help_str = "port config all speed
10|100|1000|10000|25000|40000|50000|100000|auto duplex "
WARNING: line over 80 characters
#73: FILE: app/test-pmd/cmdline.c:1159:
+ .help_str = "port config X speed
10|100|1000|10000|25000|40000|50000|100000|auto duplex "
check-git-log.sh complains about the title:
Wrong headline label:
testpmd: Add support to configure 25G and 50G speeds
Wrong headline uppercase:
testpmd: Add support to configure 25G and 50G speeds
Title should be "app/testpmd: add ...."
Could you send a separate v2 with this changes?
And probably change the bnxt patchset to 3 patches only.
Thanks,
Pablo
