Hi Yuanhan, On 10/11/2016 01:35 PM, Yuanhan Liu wrote: > Hi, > > Firstly, apologize for so late review. It's been forgotten :( > > BTW, please feel free to ping me in future if I made no response > in one or two weeks! > > I haven't reviewed it carefully yet (something I will do tomorrow). > Before that, few quick questions. > > Firstly, would you write down some test steps? Honestly, I'm not > quite sure how that works without the TCP/IP stack.
Not sure I'm getting your question. The test plan described in the cover letter works without any dpdk tcp/ip stack. It uses testpmd, which is able to bridge packets and ask for TCP segmentation. > On Mon, Oct 03, 2016 at 11:00:11AM +0200, Olivier Matz wrote: >> This patchset, targetted for 16.11, introduces the support of rx and tx >> offload in virtio pmd. To achieve this, some new mbuf flags must be >> introduced, as discussed in [1]. >> >> It applies on top of: >> - software packet type [2] >> - testpmd enhancements [3] > > I didn't do the search. Have the two got merged? As of now, it's not merged yet. I think Thomas is on it. Regards, Olivier
