2016-10-07 17:46, Bernard Iremonger: > This patchset modifies the callback function for VF management. > > A third parameter has been added to the _rte_eth_dev_callback_process > function. All references to this function have been updated. > Changes have been made to the ixgbe_rcv_msg_from_vf function to > use the new callback parameter. > > This patchset depends on the following patch. > http://dpdk.org/dev/patchwork/patch/16430/ > [dpdk-dev,v7,1/2] net/ixgbe: add API's for VF management
OK, this is probably a temporary solution. I am OK to let it enter in DPDK 16.11 and starts some discussions. That's why I'll try to sum up the situation for this patchset and the other one (API for VF management). The VF features are not yet enough standardized. So the functions to manage them from the PF will be in some specific headers (drivers/net/ixgbe/rte_pmd_ixgbe.h in this case). They could be promoted in the generic ethdev API if it appears to be generic enough. There can be also some application callbacks called from the drivers with a specific signature: - a "generic" event type for VF - a specific parameter defined in the driver Obviously, we cannot have different meanings of this event depending on the driver in use. So we must have something more robust when implementing such feature in a second driver. As there is no obvious solution, the pragmatic approach is to accept this first specific implementation while waiting for a better idea.