Hi Thomas, > Subject: Re: [dpdk-dev] [PATCH v5 01/13] librte_ether: modify internal > callback function > > 2016-10-06 15:32, Iremonger, Bernard: > > > > > 2016-10-06 12:26, Bernard Iremonger: > > > > > > void > > > > > > _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > > > > > > - enum rte_eth_event_type event) > > > > > > + enum rte_eth_event_type event, void *param) > > > > > > > > > > You need to squash the patches updating the calls to this function. > > > > > Otherwise, this patch does not compile. > > > > > > > > I will have to squash everything into one patch, separate patches > > > > will not > > > compile. > > > > > > No you can keep a separate patch for the VF event in ixgbe. > > > > I have 4 patches at present > > > > librte_ether > > net/ixgbe > > drivers/net > > app/test > > > > Would this be acceptable or do you just want everything squashed into > librte_ether except for net/ixgbe? > > You can test the compilation of each patch with this command: > git rebase -i origin/master -x scripts/test-build.sh or just: > git rebase -i origin/master -x make > > I think you need to squash drivers/net (adding just NULL param) and > app/test in ethdev patch.
They do not compile if applied one by one. Ok, I will squash drivers/net and app/test into the librte_ether patch. Regards, Bernard.
