> -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Wednesday, October 5, 2016 1:50 AM > To: Trahe, Fiona <fiona.trahe at intel.com>; dev at dpdk.org > Cc: Trahe, Fiona <fiona.trahe at intel.com>; Akhil Goyal <akhil.goyal at > nxp.com> > Subject: RE: [dpdk-dev] [PATCH v2] app/test: remove hard-coding of crypto > num qps > > Hi, > > > -----Original Message----- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Fiona Trahe > > Sent: Thursday, September 29, 2016 10:18 AM > > To: dev at dpdk.org > > Cc: De Lara Guarch, Pablo; Trahe, Fiona; Akhil Goyal > > Subject: [dpdk-dev] [PATCH v2] app/test: remove hard-coding of crypto > > num qps > > > > ts_params->conf.nb_queue_pairs should not be hard coded with device > > specific number. It should be retrieved from the device info. > > Any test which changes it should restore it to orig value. > > > > Also related cleanup of test code setting number and size of > > queue-pairs on a device, e.g. > > * Removed irrelevant ?for? loop ? was hardcoded to only loop once. > > * Removed obsolete comment re inability to free and re-allocate queu > > memory > > and obsolete workaround for it which used to create maximum size queues. > > > > And added freeing of ring memory on queue-pair release in aesni_mb > > PMD, else releasing and setting up queue-pair of a different size fails. > > > > Signed-off-by: Akhil Goyal <akhil.goyal at nxp.com> > > Signed-off-by: Fiona Trahe <fiona.trahe at intel.com> > > --- > > > > v2: > > Fix for broken QAT PMD unit tests exposed by v1 > > i.e. In test_device_configure_invalid_queue_pair_ids() after running tests > > for invalid values restore original nb_queue_pairs. > > Also cleanup of test code setting number and size of queue-pairs on a > device > > Also fix for aesni_mb PMD not freeing ring memory on qp release > > Sorry, I missed this patch. Could you split this patch into different patches? > It looks like you are making (three?) changes in different places. > > Thanks, > Pablo
Ok, will do, Fiona
