Hi Pablo, On 10/05/2016 08:45 AM, De Lara Guarch, Pablo wrote: > Hi Olivier, > >> -----Original Message----- >> diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c >> index fb2b962..56f37e6 100644 >> --- a/lib/librte_mbuf/rte_mbuf.c >> +++ b/lib/librte_mbuf/rte_mbuf.c >> @@ -319,6 +319,53 @@ const char *rte_get_rx_ol_flag_name(uint64_t mask) >> } >> } >> >> +struct flag_mask { >> + uint64_t flag; >> + uint64_t mask; >> + const char *default_name; >> +}; >> + >> +/* write the list of rx ol flags in buffer buf */ >> +int rte_get_rx_ol_flag_list(uint64_t mask, char *buf, size_t buflen) > > Return type should go in a separate line (same case in the other function).
I'll fix that too, thanks for reviewing. Olivier