2016-09-30 15:48, Sergio Gonzalez Monroy: > On 30/09/2016 15:32, David Marchand wrote: > > On Fri, Sep 23, 2016 at 12:08 PM, Tan, Jianfeng <jianfeng.tan at intel.com> > > wrote: > >>> -----Original Message----- > >>> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > >>> Sent: Friday, September 23, 2016 5:15 PM > >>> To: Thomas Monjalon > >>> Cc: dev at dpdk.org; David Marchand; Tan, Jianfeng > >>> Subject: Re: [PATCH] eal: remove single file segments related code > >>> > >>> On Fri, Sep 23, 2016 at 10:50:06AM +0200, Thomas Monjalon wrote: > >>>> 2016-09-23 15:10, Yuanhan Liu: > >>>>> Commit c711ccb30987 ("ivshmem: remove library and its EAL integration") > >>>>> removed ivshmem support, but seems David forgot to remove the another > >>>>> piece of code: code for RTE_EAL_SINGLE_FILE_SEGMENTS, which is > >>> introduced > >>>>> when ivshmem was firstly added. > >>>> It is not a mistake. We thought it is used by container use case. > >>> I think no. It would help the container case a bit, but not too much I > >>> would think, especially when the memory goes fragement. > >>> > >>> Jianfeng, IIRC, you don't use that option for container case, right? > >>> > >>> --yliu > >> No, I don't use this option for container case. As yuanhan said, it cannot > >> provide much help for virtio_user memory region number limitation. > > Ok, as said, since this feature had been introduced with ivshmem > > 40b966a211ab ("ivshmem: library changes for mmaping using ivshmem"), > > if Sergio has nothing against this removal, I am all for removing > > unused code. > > I certainly do not have anything against this removal :) > > Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy at intel.com>
Applied, thanks
