Hi Wei,
On Mon, 28 Nov 2016 09:42:12 +0100
Olivier Matz <olivier.matz at 6wind.com> wrote:
> Hi Wenzhuo,
First, sorry for the mistake in your name my previous mail.
Please find below some other comments about the patch (on the form).
> On Sun, 27 Nov 2016 10:43:47 +0800
> Wei Zhao <wei.zhao1 at intel.com> wrote:
>
> > From: zhao wei <wei.zhao1 at intel.com>
> >
> > There is a redundant repetition word "for" in commnet line of the
commnet -> comment
> > file rte_mempool.h after the definition of RTE_MEMPOOL_OPS_NAMESIZE.
> > The word "for"appear twice in line 359 and 360.One of them is
Missing space after '"for"' and after '360.'
> > redundant, so delete it.
> >
> > Fixes: 449c49b93a6b (" mempool: support handler operations")
We should have an empty line after the 'Fixes:' tag. The
check-git-log.sh can help you to notice these errors.
Also, it is important that no spaces are added in the title of the
commit. You can get the exact line with:
git log -1 --abbrev=12 --format='Fixes: %h (\"%s\")' <commitid>
> > Signed-off-by: zhao wei <wei.zhao1 at intel.com>
The name in your .gitconfig should be the same than in you mail:
Wei Zhao <wei.zhao1 at intel.com>
> > Acked-by: John McNamara <john.mcnamara at intel.com>
>
> Acked-by: Olivier Matz <olivier.matz at 6wind.com>
>
Please, could you also check the same comments in the other patch?
Last thing: when doing another version of the patch, you should add a
changelog that describes what was modified. They take place after the 3
dashes.
Thank you for contributing.
Regards,
Olivier
