On 11/22/2016 9:38 AM, Thomas Monjalon wrote: > 2016-11-22 00:34, Ferruh Yigit: >> On 11/21/2016 11:47 PM, Thomas Monjalon wrote: >>> The command >>> make examples >>> works only if target directories have the exact name of configs. >>> >>> It is more flexible to use >>> make -C examples RTE_SDK=$(pwd) RTE_TARGET=build >>> >>> Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com> >> >> Instead of removing examples & examples_clean targets, what do you think >> keeping them as wrapper to suggested usage, for backward compatibility. >> >> Something like: >> " >> BUILDING_RTE_SDK := >> export BUILDING_RTE_SDK >> >> # Build directory is given with O= >> O ?= $(RTE_SDK)/examples >> >> # Target for which examples should be built. >> T ?= build >> >> .PHONY: examples >> examples: >> @echo ================== Build examples for $(T) >> $(MAKE) -C examples O=$(abspath $(O)) RTE_TARGET=$(T); >> >> .PHONY: examples_clean >> examples_clean: >> @echo ================== Clean examples for $(T) >> $(MAKE) -C examples O=$(abspath $(O)) RTE_TARGET=$(T) clean; >> " > > What is the benefit of this makefile? Just remove -C ?
To keep existing targets, in case somebody use them. > It is not compatible with the old behaviour, so I'm afraid it would be > confusing for no real benefit. Right, not fully compatible, but still can do: make examples / make examples_clean make examples T=x86_64-native-linuxapp-gcc Overall, if you believe keeping them is confusing, I am OK with it, just may need to update doc/build-sdk-quick.txt to fix "make help" output. Thanks, ferruh
