Hi Adrien, On 11/22/2016 11:27 AM, Adrien Mazarguil wrote: > Hi Olivier, > > Neither mlx4 nor mlx5 depend on igb/uio/vfio modules, please see below. > > On Tue, Nov 22, 2016 at 10:50:57AM +0100, Olivier Matz wrote: >> Add a new macro RTE_PMD_REGISTER_KMOD_DEP() that allows a driver to >> declare the list of kernel modules required to run properly. >> >> Today, most PCI drivers require uio/vfio. >> >> Signed-off-by: Olivier Matz <olivier.matz at 6wind.com> >> Acked-by: Fiona Trahe <fiona.trahe at intel.com> >> --- > [...] >> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c >> index da61a85..a0065bf 100644 >> --- a/drivers/net/mlx4/mlx4.c >> +++ b/drivers/net/mlx4/mlx4.c >> @@ -5937,3 +5937,4 @@ rte_mlx4_pmd_init(void) >> >> RTE_PMD_EXPORT_NAME(net_mlx4, __COUNTER__); >> RTE_PMD_REGISTER_PCI_TABLE(net_mlx4, mlx4_pci_id_map); >> +RTE_PMD_REGISTER_KMOD_DEP(net_mlx4, "* igb_uio | uio_pci_generic | vfio"); > > RTE_PMD_REGISTER_KMOD_DEP(net_mlx4, "* ib_uverbs & mlx4_en & mlx4_core & > mlx4_ib"); > >> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c >> index 90cc35e..b0343f3 100644 >> --- a/drivers/net/mlx5/mlx5.c >> +++ b/drivers/net/mlx5/mlx5.c >> @@ -759,3 +759,4 @@ rte_mlx5_pmd_init(void) >> >> RTE_PMD_EXPORT_NAME(net_mlx5, __COUNTER__); >> RTE_PMD_REGISTER_PCI_TABLE(net_mlx5, mlx5_pci_id_map); >> +RTE_PMD_REGISTER_KMOD_DEP(net_mlx5, "* igb_uio | uio_pci_generic | vfio"); > > RTE_PMD_REGISTER_KMOD_DEP(net_mlx5, "* ib_uverbs & mlx5_core & mlx5_ib"); >
Thank you for reviewing. I messed up in the rebase, the v1 was closer to what you suggest, sorry. I'll send an update. Olivier
