On Sun, Nov 20, 2016 at 4:22 PM, David Marchand <david.marchand at 6wind.com> wrote: > On Sun, Nov 20, 2016 at 11:05 AM, Jan Blunck <jblunck at infradead.org> wrote: >> This is overwritten in rte_eth_dev_info_get(). >> >> Signed-off-by: Jan Blunck <jblunck at infradead.org> >> --- >> drivers/net/virtio/virtio_ethdev.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/drivers/net/virtio/virtio_ethdev.c >> b/drivers/net/virtio/virtio_ethdev.c >> index 079fd6c..741688e 100644 >> --- a/drivers/net/virtio/virtio_ethdev.c >> +++ b/drivers/net/virtio/virtio_ethdev.c >> @@ -1624,10 +1624,6 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct >> rte_eth_dev_info *dev_info) >> uint64_t tso_mask; >> struct virtio_hw *hw = dev->data->dev_private; >> >> - if (dev->pci_dev) >> - dev_info->driver_name = dev->driver->pci_drv.driver.name; >> - else >> - dev_info->driver_name = "virtio_user PMD"; >> dev_info->max_rx_queues = >> RTE_MIN(hw->max_queue_pairs, VIRTIO_MAX_RX_QUEUES); >> dev_info->max_tx_queues = >> -- >> 2.7.4 >> > > I posted something similar [1], so looks good to me :-) > > [1]: http://dpdk.org/dev/patchwork/patch/16991/ >
Thanks for reviewing. Do we go with your proposal then? Do you plan to follow up on the comments?
