2016-11-11 09:16, Alejandro Lucero: > Thomas, > > We are wondering if you realize this patch fixes a bug with current ethdev > code as a device can have more than RTE_ETHDEV_QUEUE_STAT_CNTRS. > > Maybe the commit message is giving the wrong impression and as you > commented, it should just focus on the bug it fixes and to leave for > another email thread the discussion of how to solve the > RTE_ETHDEV_QUEUE_STAT_CNTRS > problem. > > Should we remove this from patchwork and to send another patch that way?
Yes please. It was my first comment, we don't understand the exact issue you are fixing. And I have a bad feeling it could break something else (really just a feeling). It is not the kind of patch we can apply the last day of a release. That's why I think it should wait 17.02. Of course you can try to convince me and others to apply it as a last minute patch. But why are you sending a patch on the generic API in the last days? Last argument: it is not fixing a regression of 16.11, so it is not so urgent.
