On 07/11/2016 21:14, Reshma Pattan wrote:
[..]
> Signed-off-by: Reshma Pattan <reshma.pattan at intel.com>
Reviewed-by: Remy Horton <remy.horton at intel.com>
> +static void
> +metrics_display(int port_id)
> +{
> + struct rte_stat_value *stats;
> + struct rte_metric_name *names;
Note that rte_stats_value is being renamed to rte_metric_value in the
next version of the metrics library..
> +int
> +rte_latencystats_init(uint64_t samp_intvl,
> + rte_latency_stats_flow_type_fn user_cb)
> +{
Far as I can tell, user_cb is always NULL, and the two callbacks it
eventually get passed to don't use it. There any reason the function
signature has it at all?
> +++ b/lib/librte_latencystats/rte_latencystats_version.map
> @@ -0,0 +1,10 @@
> +DPDK_16.11 {
This will need to change to 17.02 once new release cycle starts. :)
Will also need to add entry to release_17_02.rst once it becomes available..
..Remy
