Hi Thomas,

> 2016-11-10 13:50, Mori, Naoyuki:
> > >    Thomas wrote:
> > >     > Just to make it sure, you mean returning an error in the driver when
> > >     > a configuration cannot be applied, right?
> > >
> > >    Yes, as in 1bbcc5d21129 ("i40evf: report error for unsupported CRC
> > >    stripping config"), where -EINVAL is returned.
> > >
> > >    Bj?rn
> >
> > On my experience, OvS+DPDK has same issue.
> > You cannot run OvS on i40evf due to this CRC config mismatch, while OvS on
> ixgbevf works fine.
> > So, changing on i40evf PMD side would have more benefit, I believe.
> 
> No I think OVS should handle the configuration error.
> We could also add a function to query this capability before configuring.

That would be fine, as long as it became a well-known standard.
But at least, hope i40evf and ixgbevf to be consistent in this CRC handling.


Thanks,
Mori

Reply via email to