Hi Deepak, > -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Deepak Kumar Jain > Sent: Monday, May 23, 2016 4:47 PM > To: Doherty, Declan > Cc: Jain, Deepak K; dev at dpdk.org > Subject: [dpdk-dev] [PATCH] crypto: fix control issues in aesni pmd >
Since this patch is for the AES-NI Multi Buffer PMD, you should change the title to "aesni_mb: fix...", and of couse without to including then aesni pmd again :) > From: "Jain, Deepak K" <deepak.k.jain at intel.com> > > Fix the control issues for return value Maybe a more descriptive commit would be something like "Fix wrong indentation for return value", probably applicable for the title too. > > Fixes: 924e84f87306 ("aesni_mb: add driver for multi buffer based crypto") > Coverity ID 126585 Also, take a look at this email and change the commit accordingly, as it fixes a Coverity issue: http://dpdk.org/ml/archives/dev/2016-May/039650.html Thanks, Pablo > > Signed-off-by: Deepak Kumar Jain <deepak.k.jain at intel.com> > --- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > index 3415ac1..9c42f88 100644 > --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > @@ -560,7 +560,7 @@ aesni_mb_pmd_enqueue_burst(void *queue_pair, > struct rte_crypto_op **ops, > goto flush_jobs; > else > qp->stats.enqueued_count += processed_jobs; > - return i; > + return i; > > flush_jobs: > /* > -- > 2.5.5