2016-05-31 09:39, Olivier MATZ: > Hi Thomas, > > On 05/30/2016 09:44 PM, Thomas Monjalon wrote: > > 2016-05-30 14:04, Olivier Matz: > >> Enhance the logs related to mbuf pool creation. Display an info level > >> log when creating the mbuf, and display the error as a string on failure. > >> > >> After the patch, we have: > >> > >> [...] > >> EAL: probe driver: 8086:10fb rte_ixgbe_pmd > >> USER1: create a new mbuf pool <mbuf_pool_socket_0>: n=331456, \ > >> size=2176, socket=0 > >> EAL: Error - exiting with code: 1 > >> Cause: Creation of mbuf pool for socket 0 failed: Cannot allocate \ > >> memory > > > > Yes printing the error reason is a good improvement. > > But why the previous line is at INFO level? It looks to be a debug. > > > > Using INFO instead of DEBUG was done on purpose. I think the mbuf > pool parameters is a valuable information for the user running testpmd, > especially to ensure it's compatible with best performance.
OK, seems reasonnable.
