> -----Original Message----- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Monday, May 23, 2016 11:25 PM > To: Pattan, Reshma <reshma.pattan at intel.com> > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 3/9] librte_ether: add new fields to > rte_eth_dev_info struct > > On Mon, 23 May 2016 22:38:26 +0100 > Reshma Pattan <reshma.pattan at intel.com> wrote: > > > Add new fields to rte_eth_dev_info struct New fields nb_rx_queues and > > nb_tx_queues are added to rte_eth_dev_info structure. > > Changes to API rte_eth_dev_info_get() are done to update these new > > fields to rte_eth_dev_info object. > > > > Signed-off-by: Reshma Pattan <reshma.pattan at intel.com> > > This is an ABI break because rte_dev_info_get will clobber the the stack of > the > caller if the caller thinks dev_info is old size.
Yes and the ABI breakage was announced as RFC earlier, please check the below mails, now this is formal patch for the same. http://dpdk.org/ml/archives/dev/2016-April/037458.html http://dpdk.org/ml/archives/dev/2016-April/037459.html http://dpdk.org/ml/archives/dev/2016-April/037460.html Thanks, Reshma