Olivier, The patch set looks good. I think little endian is good enough. We internally decide to only support little endian previously. You can keep the endian conversion such kind of things in the code.
-----Original Message----- From: Olivier Matz [mailto:olivier.m...@6wind.com] Sent: 2016?5?20? 20:11 To: Chao Zhu <chaozhu at linux.vnet.ibm.com>; dev at dpdk.org Cc: david.marchand at 6wind.com; yuanhan.liu at linux.intel.com; huawei.xie at intel. com Subject: Re: [PATCH v2 6/7] virtio: fix pci accesses for ppc64 in legacy mode Hi Chao, On 05/19/2016 11:13 AM, Chao Zhu wrote: > Olivier, > > Thanks for the patches! > Just one comment: > POWER8 machine only supports little endian OS on bare metal. In VM > guest, it can support both little endian and big endian OS. Did you > try to run it on both host (little endian) and guest (big endian and little endian)? No I didn't test big endian in the guest. I don't have any big endian VM image. Is it required for the test? I mean, is it possible to run a big endian DPDK userland application on a little endian kernel? (and if yes, is it known to work?) Maybe I could replace in the patch: #ifdef RTE_ARCH_PPC_64 By something like : #if defined(RTE_ARCH_PPC_64) && (RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN) If you have the ability to test it easily, it would be appreciated :) Thanks for the review! Olivier
