-----Original Message----- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Thursday, May 19, 2016 8:57 PM To: Yang, Ziye <ziye.yang at intel.com> Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH] pci: Add the class_id support in pci probe
2016-05-19 12:18, Yang, Ziye: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > 2016-05-11 14:08, Ziye Yang: > > + dev->id.class_id = (uint32_t)tmp && CLASS_ANY_ID; > > Should be a bitwise &. Why masking is needed? > [Ziye] Only 24bit info is needed. What are the other bits? Please put a comment in the code. [Ziye] Revision ID is defined in pci spec, classid has 24 bits. And when we read from the system, we will only get class_id, subclass and program interface. I will put the comment
